Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: query params: parse list failed, unsupported message type: "google.protobuf.Struct" #1967 #1989

Merged
merged 2 commits into from
May 17, 2022
Merged

fix: query params: parse list failed, unsupported message type: "google.protobuf.Struct" #1967 #1989

merged 2 commits into from
May 17, 2022

Conversation

imzhongqi
Copy link
Contributor

@imzhongqi imzhongqi commented May 17, 2022 •
edited

Description (what this PR does / why we need it):

fix: query params: parse list failed, unsupported message type: "google.protobuf.Struct" #1967

Which issue(s) this PR fixes (resolves / be part of):

fixes #

#1967

Other special notes for reviewer:

@shenqidebaozi
Copy link
Sponsor Member

Please complete the title information

@shenqidebaozi shenqidebaozi linked an issue May 17, 2022 that may be closed by this pull request
query params: parse list failed, unsupported message type: \"google.protobuf.Struct\" #1967
Closed
@imzhongqi imzhongqi changed the title fix: #1967 fix: query params: parse list failed, unsupported message type: "google.protobuf.Struct" #1967 May 17, 2022
@imzhongqi
Copy link
Contributor Author

imzhongqi commented May 17, 2022 •
edited

all right

Please complete the title information

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2022 •
edited

Codecov Report

Merging #1989 (5c70292) into main (ed144f6) will increase coverage by 0.02%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main    #1989      +/-   ##
==========================================
+ Coverage   80.71%   80.74%   +0.02%     
==========================================
  Files          82       82              
  Lines        3635     3640       +5     
==========================================
+ Hits         2934     2939       +5     
+ Misses        494      493       -1     
- Partials      207      208       +1
Impacted Files Coverage Δ
encoding/form/proto_decode.go 54.01% <60.00%> (+0.13%) ⬆️
internal/context/context.go 100.00% <0.00%> (+2.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed144f6...5c70292. Read the comment docs.

@tonybase tonybase merged commit c8c870b into go-kratos:main May 17, 2022
tonybase pushed a commit that referenced this pull request May 31, 2022
@imzhongqi @tonybase
fix: query params: parse list failed, unsupported message type: "goog…
ced122a 
…le.protobuf.Struct" #1967 (#1989)

* feat: Support google.protobuf.Struct in query parameters.

* style: add a blank line in test proto file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenqidebaozi shenqidebaozi shenqidebaozi left review comments

@tonybase tonybase tonybase approved these changes

@daemon365 daemon365 Awaiting requested review from daemon365

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

query params: parse list failed, unsupported message type: \"google.protobuf.Struct\"
4 participants
@imzhongqi @shenqidebaozi @codecov-commenter @tonybase