Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add logrus to contrib log #2077

Merged
merged 6 commits into from
Jul 7, 2022
Merged

Conversation

Betula-L
Copy link
Contributor

@Betula-L Betula-L commented Jun 2, 2022

Description (what this PR does / why we need it):

Recovery logrus as thiry-party log component to contrib/log.

It added to exmples in PR #1124, but it seems that has been remove in PR #1871

@Betula-L Betula-L changed the title add logrus to contrib log log: add logrus to contrib log Jun 2, 2022
tonybase
tonybase previously approved these changes Jun 2, 2022
@tonybase tonybase added this to the v2.4.0 milestone Jun 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2022

Codecov Report

Merging #2077 (057c475) into main (95dce00) will increase coverage by 0.00%.
The diff coverage is 68.42%.

❗ Current head 057c475 differs from pull request most recent head 42622c2. Consider uploading reports for the commit 42622c2 to get more accurate results

@@           Coverage Diff           @@
##             main    #2077   +/-   ##
=======================================
  Coverage   79.07%   79.08%           
=======================================
  Files          83       84    +1     
  Lines        3671     3696   +25     
=======================================
+ Hits         2903     2923   +20     
- Misses        558      560    +2     
- Partials      210      213    +3     
Impacted Files Coverage Δ
encoding/form/well_known_types.go 77.27% <ø> (ø)
transport/http/codec.go 65.90% <0.00%> (ø)
selector/default_selector.go 80.95% <33.33%> (-3.67%) ⬇️
app.go 83.83% <60.00%> (+0.67%) ⬆️
encoding/form/proto_encode.go 71.73% <64.70%> (-0.27%) ⬇️
selector/peer.go 100.00% <100.00%> (ø)
transport/grpc/client.go 93.10% <100.00%> (+0.16%) ⬆️
transport/http/binding/encode.go 81.39% <100.00%> (+0.90%) ⬆️
transport/http/client.go 79.12% <100.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95dce00...42622c2. Read the comment docs.

tonybase
tonybase previously approved these changes Jun 3, 2022
@shenqidebaozi shenqidebaozi changed the title log: add logrus to contrib log feat: add logrus to contrib log Jun 3, 2022
Windfarer
Windfarer previously approved these changes Jun 4, 2022
@shenqidebaozi
Copy link
Sponsor Member

please fix lint err

@Betula-L Betula-L dismissed stale reviews from Windfarer and tonybase via 800b107 July 6, 2022 07:07
@tonybase tonybase merged commit e09d294 into go-kratos:main Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants