-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: kratos proto server cmd method name bugfix (#2089) #2094
fix: kratos proto server cmd method name bugfix (#2089) #2094
Conversation
raw34
commented
Jun 10, 2022
•
edited
edited
- add ucFirst function and unit test at cmd/kratos/internal/proto/server/server.go
- fix the method name style bug
this commit just fix the part2 problem(which i affects me), like this:
|
OH~Do you mean this PR is still working in progress? |
the fact is i didn't find out the issue is about 2 problems, hah... i can try to resolve the part1 problem some time later |
Codecov Report
@@ Coverage Diff @@
## main #2094 +/- ##
==========================================
- Coverage 79.09% 79.03% -0.06%
==========================================
Files 84 84
Lines 3683 3683
==========================================
- Hits 2913 2911 -2
- Misses 559 561 +2
Partials 211 211
Continue to review full report at Codecov.
|
It seems that the problem is caused by this modification |
yes, it is. the modification fix another bug, but trigger this bug. and my commit can fix it. |
Has this PR been completed? |