Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add servicecomb registry #2114

Merged
merged 8 commits into from
Aug 15, 2022
Merged

feat: add servicecomb registry #2114

merged 8 commits into from
Aug 15, 2022

Conversation

kkf1
Copy link
Contributor

@kkf1 kkf1 commented Jun 18, 2022

Description (what this PR does / why we need it):

Adding servicecomb registry enables developers to use servicecomb registry center on Kratos

Which issue(s) this PR fixes (resolves / be part of):

Other special notes for the reviewers:

contrib/registry/servicecomb/registry.go Outdated Show resolved Hide resolved
contrib/registry/servicecomb/registry.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2022

Codecov Report

Merging #2114 (bf9935e) into main (6fa5700) will increase coverage by 6.44%.
The diff coverage is n/a.

❗ Current head bf9935e differs from pull request most recent head cec15d8. Consider uploading reports for the commit cec15d8 to get more accurate results

@@            Coverage Diff             @@
##             main    #2114      +/-   ##
==========================================
+ Coverage   79.09%   85.53%   +6.44%     
==========================================
  Files          84       87       +3     
  Lines        3683     3796     +113     
==========================================
+ Hits         2913     3247     +334     
+ Misses        559      381     -178     
+ Partials      211      168      -43     
Impacted Files Coverage Δ
log/value.go 91.66% <0.00%> (-8.34%) ⬇️
transport/grpc/server.go 85.86% <0.00%> (-1.64%) ⬇️
encoding/form/proto_encode.go 71.32% <0.00%> (-0.68%) ⬇️
transport/grpc/codec.go 28.57% <0.00%> (ø)
transport/http/router.go 100.00% <0.00%> (ø)
transport/http/binding/bind.go 100.00% <0.00%> (ø)
encoding/form/well_known_types.go 77.27% <0.00%> (ø)
middleware/ratelimit/ratelimit.go 100.00% <0.00%> (ø)
middleware/circuitbreaker/circuitbreaker.go 100.00% <0.00%> (ø)
internal/matcher/middleware.go 95.65% <0.00%> (ø)
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kkf1 kkf1 requested a review from tonybase August 15, 2022 12:25
@tonybase tonybase merged commit d11c689 into go-kratos:main Aug 15, 2022
xiongpan828 pushed a commit to xiongpan828/kratos that referenced this pull request Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants