Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(contrib): add unit test for opensergo.go #2137

Merged
merged 5 commits into from
Jun 29, 2022

Conversation

zoujiejun
Copy link
Contributor

Description (what this PR does / why we need it):

coverage: 88.0% of statements

Which issue(s) this PR fixes (resolves / be part of):

part of #2135

@daemon365
Copy link
Member

Please fix lint, use make fix

@zoujiejun
Copy link
Contributor Author

Please fix lint, use make fix

fixed

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2022

Codecov Report

Merging #2137 (beb83ab) into main (25c5996) will not change coverage.
The diff coverage is n/a.

❗ Current head beb83ab differs from pull request most recent head 8496457. Consider uploading reports for the commit 8496457 to get more accurate results

@@           Coverage Diff           @@
##             main    #2137   +/-   ##
=======================================
  Coverage   79.08%   79.08%           
=======================================
  Files          84       84           
  Lines        3696     3696           
=======================================
  Hits         2923     2923           
  Misses        560      560           
  Partials      213      213           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25c5996...8496457. Read the comment docs.

Copy link
Member

@daemon365 daemon365 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Sponsor Member

@shenqidebaozi shenqidebaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenqidebaozi shenqidebaozi merged commit 3905182 into go-kratos:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants