Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contrib):add etcd watcher withKeysOnly option #2146

Merged
merged 1 commit into from
Jul 4, 2022
Merged

feat(contrib):add etcd watcher withKeysOnly option #2146

merged 1 commit into from
Jul 4, 2022

Conversation

upuplouis
Copy link
Contributor

@upuplouis upuplouis commented Jun 30, 2022

Description (what this PR does / why we need it):

read value from etcd twice if no such opOption

Which issue(s) this PR fixes (resolves / be part of):

Other special notes for the reviewers:

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2022

Codecov Report

Merging #2146 (91d053d) into main (4ca25e4) will not change coverage.
The diff coverage is n/a.

❗ Current head 91d053d differs from pull request most recent head e60ed87. Consider uploading reports for the commit e60ed87 to get more accurate results

@@           Coverage Diff           @@
##             main    #2146   +/-   ##
=======================================
  Coverage   79.08%   79.08%           
=======================================
  Files          84       84           
  Lines        3696     3696           
=======================================
  Hits         2923     2923           
  Misses        560      560           
  Partials      213      213           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ca25e4...e60ed87. Read the comment docs.

Copy link
Member

@daemon365 daemon365 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonybase tonybase merged commit 52031f1 into go-kratos:main Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants