Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(options): increase tests coverage #2183

Merged
merged 1 commit into from
Jul 10, 2022

Conversation

jakezhu9
Copy link
Contributor

Description (what this PR does / why we need it):

Which issue(s) this PR fixes (resolves / be part of):

Part of #2147

Other special notes for the reviewers:

Copy link
Member

@daemon365 daemon365 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2022

Codecov Report

Merging #2183 (50834c2) into main (187c65b) will increase coverage by 2.45%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2183      +/-   ##
==========================================
+ Coverage   82.22%   84.67%   +2.45%     
==========================================
  Files          86       86              
  Lines        3747     3746       -1     
==========================================
+ Hits         3081     3172      +91     
+ Misses        480      408      -72     
+ Partials      186      166      -20     
Impacted Files Coverage Δ
internal/context/context.go 97.01% <0.00%> (-2.99%) ⬇️
transport/http/context.go 94.04% <0.00%> (+2.38%) ⬆️
transport/http/server.go 82.53% <0.00%> (+5.55%) ⬆️
transport/http/client.go 85.16% <0.00%> (+6.04%) ⬆️
options.go 100.00% <0.00%> (+8.33%) ⬆️
transport/transport.go 100.00% <0.00%> (+9.09%) ⬆️
transport/grpc/resolver/discovery/resolver.go 87.50% <0.00%> (+10.71%) ⬆️
transport/grpc/resolver/direct/builder.go 100.00% <0.00%> (+12.50%) ⬆️
transport/http/binding/encode.go 100.00% <0.00%> (+18.60%) ⬆️
transport/grpc/resolver/discovery/builder.go 100.00% <0.00%> (+21.27%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 187c65b...50834c2. Read the comment docs.

@shenqidebaozi shenqidebaozi merged commit afd108c into go-kratos:main Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants