Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve app test #2190

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Conversation

walrusyu
Copy link
Contributor

Description (what this PR does / why we need it):

  • add a test(TestApp_buildInstance) for buildInstance in app_test.go
  • modify the TestApp_Endpoint in app_test.go
  • move the tests for NewContext and FromContext into TestApp_Context in app_test.go

Which issue(s) this PR fixes (resolves / be part of):

resolves part of #2147

Other special notes for the reviewers:

@tonybase tonybase merged commit d1da8aa into go-kratos:main Jul 14, 2022
xiongpan828 pushed a commit to xiongpan828/kratos that referenced this pull request Jan 5, 2023
* modify app_test.go

* merge NewContext and FromContext into one test

Co-authored-by: Yu Weifeng <yu.weifeng@bcrdteam.onmicrosoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants