Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support passing program args with run cmd #2207

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

Nomango
Copy link
Contributor

@Nomango Nomango commented Jul 18, 2022

implementation of #2169

Description (what this PR does / why we need it):

Which issue(s) this PR fixes (resolves / be part of):

Other special notes for the reviewers:

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2022

Codecov Report

Merging #2207 (2e02d23) into main (1ab3d8f) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2207      +/-   ##
==========================================
+ Coverage   85.68%   85.73%   +0.05%     
==========================================
  Files          86       86              
  Lines        3758     3758              
==========================================
+ Hits         3220     3222       +2     
+ Misses        371      369       -2     
  Partials      167      167              
Impacted Files Coverage Δ
internal/context/context.go 100.00% <0.00%> (+2.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ab3d8f...2e02d23. Read the comment docs.

@tonybase tonybase added the enhancement New feature or request label Jul 27, 2022
@tonybase tonybase added this to the v2.4.1 milestone Jul 27, 2022
@tonybase tonybase merged commit 59b758c into go-kratos:main Jul 27, 2022
xiongpan828 pushed a commit to xiongpan828/kratos that referenced this pull request Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants