Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contrib/config/polaris): Use injected client properly #2238

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

paulip1792
Copy link
Contributor

Description (what this PR does / why we need it):

Injected polaris config client api is not used properly.

Which issue(s) this PR fixes (resolves / be part of):

Use injected client properly.

Other special notes for the reviewers:

@codecov-commenter
Copy link

Codecov Report

Merging #2238 (eaf16ee) into main (14cfd65) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2238   +/-   ##
=======================================
  Coverage   85.73%   85.73%           
=======================================
  Files          86       86           
  Lines        3758     3758           
=======================================
  Hits         3222     3222           
  Misses        369      369           
  Partials      167      167           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14cfd65...eaf16ee. Read the comment docs.

@tonybase tonybase merged commit 92b3c8f into go-kratos:main Jul 27, 2022
@tonybase tonybase added the bug Something isn't working label Jul 27, 2022
@tonybase tonybase added this to the v2.4.1 milestone Jul 27, 2022
@tonybase tonybase added enhancement New feature or request and removed bug Something isn't working labels Jul 27, 2022
xiongpan828 pushed a commit to xiongpan828/kratos that referenced this pull request Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants