fix(log): DefaultCaller doesn't returns "pkg/file:line", it returns "… #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…file:line" now. For example, both biz/user.go and data/user.go are printed as user.go in logger. It's not clear.
tonybase
approved these changes
Aug 13, 2022
Codecov Report
@@ Coverage Diff @@
## main #2274 +/- ##
==========================================
- Coverage 85.57% 85.48% -0.10%
==========================================
Files 87 87
Lines 3793 3796 +3
==========================================
- Hits 3246 3245 -1
- Misses 380 383 +3
- Partials 167 168 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
xiongpan828
pushed a commit
to xiongpan828/kratos
that referenced
this pull request
Jan 5, 2023
…file:line" now. For example, both biz/user.go and data/user.go are printed as user.go in logger. It's not clear. (go-kratos#2274) Co-authored-by: SeniorPlayer <SeniorPlayer@gg.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (what this PR does / why we need it):
DefaultCaller doesn't returns "pkg/file:line", it returns "file:line" now. For example, both biz/user.go and data/user.go are printed as "user.go" in logger. It's not clear.
With this PR, the log changed from
to
Which issue(s) this PR fixes (resolves / be part of):
None
Other special notes for the reviewers: