Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint): Using deprecated package io/ioutil cause lint interrupte… #2353

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

hrygo
Copy link
Contributor

@hrygo hrygo commented Sep 2, 2022

…d, change to os or io package.

Description (what this PR does / why we need it):

Using deprecated package io/ioutil cause lint interrupted, change to os or io package.

Which issue(s) this PR fixes (resolves / be part of):

fixes/resolves #2351

Other special notes for the reviewers:

No.

Copy link
Member

@kagaya85 kagaya85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution!

@codecov-commenter
Copy link

Codecov Report

Merging #2353 (5979c23) into main (60b00c8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2353   +/-   ##
=======================================
  Coverage   85.27%   85.27%           
=======================================
  Files          88       88           
  Lines        3775     3775           
=======================================
  Hits         3219     3219           
  Misses        391      391           
  Partials      165      165           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@shenqidebaozi shenqidebaozi merged commit 617ee1a into go-kratos:main Sep 2, 2022
@hrygo hrygo deleted the feature-lint branch September 2, 2022 07:09
hrygo added a commit to hrygo/kratos that referenced this pull request Sep 8, 2022
…d, change to `os` or `io` package. (go-kratos#2353)

Co-authored-by: 黄仲辉 <610195979@qq.com>
Loner1024 pushed a commit to Loner1024/kratos that referenced this pull request Sep 9, 2022
…d, change to `os` or `io` package. (go-kratos#2353)

Co-authored-by: 黄仲辉 <610195979@qq.com>
xiongpan828 pushed a commit to xiongpan828/kratos that referenced this pull request Jan 5, 2023
…d, change to `os` or `io` package. (go-kratos#2353)

Co-authored-by: 黄仲辉 <610195979@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

使用了io/ioutil包中的过期方法导致执行make lint被中止
5 participants