Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metadata): sort services by lexicographical order on ListServices #2397

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

deagon
Copy link
Contributor

@deagon deagon commented Sep 22, 2022

It's out of order on the reply of ListServices, which is so complex for human reading.

image

@codecov-commenter
Copy link

Codecov Report

Merging #2397 (cc8a5f8) into main (7866ff7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2397   +/-   ##
=======================================
  Coverage   85.36%   85.36%           
=======================================
  Files          88       88           
  Lines        3764     3764           
=======================================
  Hits         3213     3213           
  Misses        384      384           
  Partials      167      167           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@deagon
Copy link
Contributor Author

deagon commented Sep 22, 2022

recheck

@Cluas Cluas requested a review from longXboy September 24, 2022 15:30
@tonybase tonybase merged commit 4030067 into go-kratos:main Oct 18, 2022
xiongpan828 pushed a commit to xiongpan828/kratos that referenced this pull request Jan 5, 2023
…go-kratos#2397)

Co-authored-by: Guoqiang Ding <guoqiang10@staff.sina.com.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants