Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add app Before and Afters option #2403

Merged
merged 5 commits into from
Nov 7, 2022
Merged

feat: add app Before and Afters option #2403

merged 5 commits into from
Nov 7, 2022

Conversation

JellyTony
Copy link
Contributor

Description (what this PR does / why we need it):

add app Before and Afters option

Which issue(s) this PR fixes (resolves / be part of):

Other special notes for the reviewers:

tonybase
tonybase previously approved these changes Sep 27, 2022
options.go Outdated Show resolved Hide resolved
tonybase
tonybase previously approved these changes Oct 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2022

Codecov Report

Merging #2403 (eee8e48) into main (dcae38d) will increase coverage by 0.02%.
The diff coverage is 83.33%.

❗ Current head eee8e48 differs from pull request most recent head d35e800. Consider uploading reports for the commit d35e800 to get more accurate results

@@            Coverage Diff             @@
##             main    #2403      +/-   ##
==========================================
+ Coverage   84.91%   84.94%   +0.02%     
==========================================
  Files          88       88              
  Lines        3799     3812      +13     
==========================================
+ Hits         3226     3238      +12     
+ Misses        405      404       -1     
- Partials      168      170       +2     
Impacted Files Coverage Δ
app.go 83.78% <72.22%> (-2.08%) ⬇️
options.go 100.00% <100.00%> (ø)
config/file/watcher.go 59.37% <0.00%> (-6.25%) ⬇️
config/file/file.go 61.90% <0.00%> (-4.77%) ⬇️
selector/node/ewma/node.go 86.81% <0.00%> (-0.15%) ⬇️
log/level.go 100.00% <0.00%> (ø)
transport/http/server.go 75.83% <0.00%> (+1.32%) ⬆️
middleware/metadata/metadata.go 100.00% <0.00%> (+8.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tonybase tonybase merged commit 590c469 into go-kratos:main Nov 7, 2022
xiongpan828 pushed a commit to xiongpan828/kratos that referenced this pull request Jan 5, 2023
* feat: add app Before and Afters option

* feat: before and Afters with context params

* style: declaration of "err" shadows declaration

Co-authored-by: JeffreyBool <zhanggaoyuan@mediatrack.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants