fix: call defer in for loop
#2411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resource leakage may occur. Call 'defer' in the 'for' loop. case: https://go.dev/doc/effective_go#defer
Codecov Report
@@ Coverage Diff @@
## main #2411 +/- ##
==========================================
+ Coverage 85.31% 85.36% +0.05%
==========================================
Files 88 88
Lines 3765 3765
==========================================
+ Hits 3212 3214 +2
+ Misses 386 384 -2
Partials 167 167
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tonybase
approved these changes
Oct 18, 2022
xiongpan828
pushed a commit
to xiongpan828/kratos
that referenced
this pull request
Jan 5, 2023
Resource leakage may occur. Call 'defer' in the 'for' loop. case: https://go.dev/doc/effective_go#defer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (what this PR does / why we need it):
Resource leakage may occur. Call 'defer' in the 'for' loop.
case: https://go.dev/doc/effective_go#defer
Which issue(s) this PR fixes (resolves / be part of):
Other special notes for the reviewers: