cleanup: using constants instead of literals #2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demoManito
force-pushed
the
cleanup/http-method
branch
from
7824ca3
to
63f6316
Compare
Codecov Report
@@ Coverage Diff @@
## main #2412 +/- ##
=======================================
Coverage 84.79% 84.79%
=======================================
Files 88 88
Lines 3796 3796
=======================================
Hits 3219 3219
Misses 407 407
Partials 170 170 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Cluas
changed the title
demoManito
force-pushed
the
cleanup/http-method
branch
from
63f6316
to
d4856e3
Compare
|
rebase upstream main, please code review @Cluas @haiyux |
Cluas
approved these changes
Oct 18, 2022
tonybase
approved these changes
Oct 18, 2022
xiongpan828
pushed a commit
to xiongpan828/kratos
that referenced
this pull request
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (what this PR does / why we need it):
use http package methods
Which issue(s) this PR fixes (resolves / be part of):
Other special notes for the reviewers: