Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(config): code style tweaks and abstracts some methods #2465

Merged
merged 3 commits into from
Nov 2, 2022

Conversation

demoManito
Copy link
Member

Description (what this PR does / why we need it):

  • code style tweaks
  • abstracts some methods

Which issue(s) this PR fixes (resolves / be part of):

Other special notes for the reviewers:

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2022

Codecov Report

Merging #2465 (e85ed94) into main (dcae38d) will decrease coverage by 0.13%.
The diff coverage is 74.41%.

@@            Coverage Diff             @@
##             main    #2465      +/-   ##
==========================================
- Coverage   84.91%   84.78%   -0.14%     
==========================================
  Files          88       88              
  Lines        3799     3805       +6     
==========================================
  Hits         3226     3226              
- Misses        405      407       +2     
- Partials      168      172       +4     
Impacted Files Coverage Δ
config/config.go 54.66% <0.00%> (ø)
config/env/watcher.go 100.00% <ø> (ø)
config/file/watcher.go 59.37% <ø> (-6.25%) ⬇️
config/value.go 47.50% <72.41%> (+0.08%) ⬆️
config/env/env.go 94.11% <100.00%> (ø)
config/reader.go 81.00% <100.00%> (+0.38%) ⬆️
config/file/file.go 61.90% <0.00%> (-4.77%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tonybase tonybase merged commit 2a65502 into go-kratos:main Nov 2, 2022
@demoManito demoManito deleted the style/config-code branch November 3, 2022 09:45
xiongpan828 pushed a commit to xiongpan828/kratos that referenced this pull request Jan 5, 2023
…s#2465)

* style(config): code specification tweaks and abstracts some methods

* optimize

* modify func location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants