fix(selector): set global do not work #2489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2489 +/- ##
==========================================
+ Coverage 84.88% 85.18% +0.29%
==========================================
Files 88 88
Lines 3805 3826 +21
==========================================
+ Hits 3230 3259 +29
+ Misses 405 393 -12
- Partials 170 174 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tonybase
reviewed
Nov 7, 2022
|
@tonybase @shenqidebaozi PTAL |
tonybase
approved these changes
Nov 8, 2022
shenqidebaozi
approved these changes
Nov 9, 2022
xiongpan828
pushed a commit
to xiongpan828/kratos
that referenced
this pull request
Jan 5, 2023
* fix(selector): set global do not work * fix(selector): test * fix(selector): return early * fix(selector): use struct * fix(selector): use struct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (what this PR does / why we need it):
fix #2488
Which issue(s) this PR fixes (resolves / be part of):
Other special notes for the reviewers: