Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change the working directory of the command #2560

Merged
merged 3 commits into from
Mar 16, 2023

Conversation

starmilkxin
Copy link
Contributor

Refs #2519

Description (what this PR does / why we need it):

This pr changes the working directory of the command run, so that the file creation operation is relative to the project root directory.

Which issue(s) this PR fixes (resolves / be part of):

fixes #2519

Other special notes for the reviewers:

@shenqidebaozi
Copy link
Sponsor Member

I think we should add a work configuration directly instead of modifying the existing logic

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2022

Codecov Report

Merging #2560 (0f48ebf) into main (7eca8f8) will not change coverage.
The diff coverage is n/a.

❗ Current head 0f48ebf differs from pull request most recent head d997601. Consider uploading reports for the commit d997601 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #2560   +/-   ##
=======================================
  Coverage   84.88%   84.88%           
=======================================
  Files          88       88           
  Lines        3889     3889           
=======================================
  Hits         3301     3301           
  Misses        413      413           
  Partials      175      175           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@starmilkxin
Copy link
Contributor Author

I think we should add a work configuration directly instead of modifying the existing logic

Could you be more specific? Is it similar to adding a configuration item to the source code to determine whether the kratos working directory is the project root directory, or adding an argument after "kratos run" ?

@shenqidebaozi
Copy link
Sponsor Member

kratos run -work=xxxxx

@starmilkxin
Copy link
Contributor Author

please code review @shenqidebaozi

@shenqidebaozi shenqidebaozi merged commit d057293 into go-kratos:main Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kratos run目录问题
5 participants