Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support polaris ratelimit ability #2586

Merged
merged 13 commits into from
Feb 13, 2023

Conversation

huyuanxin
Copy link
Contributor

@huyuanxin huyuanxin commented Dec 14, 2022

Description (what this PR does / why we need it):

#2566

Which issue(s) this PR fixes (resolves / be part of):

Other special notes for the reviewers:

@huyuanxin huyuanxin changed the title [Feature] support polaris ratelimit ability #2566 [Feature] support polaris ratelimit ability Dec 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2022

Codecov Report

Merging #2586 (3cdb33e) into main (2391211) will decrease coverage by 0.06%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #2586      +/-   ##
==========================================
- Coverage   84.87%   84.82%   -0.06%     
==========================================
  Files          88       88              
  Lines        3875     3875              
==========================================
- Hits         3289     3287       -2     
- Misses        411      413       +2     
  Partials      175      175              
Impacted Files Coverage Δ
internal/context/context.go 97.01% <0.00%> (-2.99%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@huyuanxin huyuanxin reopened this Dec 22, 2022
@huyuanxin huyuanxin marked this pull request as ready for review December 22, 2022 01:48
@shenqidebaozi shenqidebaozi changed the title [Feature] support polaris ratelimit ability feat: support polaris ratelimit ability Jan 9, 2023
@huyuanxin
Copy link
Contributor Author

test watch test failed

shenqidebaozi
shenqidebaozi previously approved these changes Jan 13, 2023
Copy link
Sponsor Member

@shenqidebaozi shenqidebaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenqidebaozi shenqidebaozi merged commit 0a07644 into go-kratos:main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants