Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: grpc use the admin api #2596

Merged
merged 2 commits into from
Jan 2, 2023
Merged

feat: grpc use the admin api #2596

merged 2 commits into from
Jan 2, 2023

Conversation

shenqidebaozi
Copy link
Sponsor Member

Description (what this PR does / why we need it):

support grpcdebug
https://github.com/grpc-ecosystem/grpcdebug

Which issue(s) this PR fixes (resolves / be part of):

Other special notes for the reviewers:

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2022

Codecov Report

Merging #2596 (96d3148) into main (a017ab0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2596      +/-   ##
==========================================
+ Coverage   85.16%   85.17%   +0.01%     
==========================================
  Files          88       88              
  Lines        3835     3838       +3     
==========================================
+ Hits         3266     3269       +3     
  Misses        396      396              
  Partials      173      173              
Impacted Files Coverage Δ
transport/grpc/server.go 83.83% <100.00%> (+0.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

transport/grpc/server.go Outdated Show resolved Hide resolved
Copy link
Member

@tonybase tonybase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonybase tonybase merged commit 480b16b into main Jan 2, 2023
@tonybase tonybase deleted the feat/grpc-service branch January 2, 2023 13:32
xiongpan828 pushed a commit to xiongpan828/kratos that referenced this pull request Jan 5, 2023
* feat: grpc use the admin api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants