Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add latency to the recover handler context #2653

Merged
merged 4 commits into from
Feb 23, 2023

Conversation

hoslo
Copy link
Contributor

@hoslo hoslo commented Feb 6, 2023

Description (what this PR does / why we need it):

Add latency to the recover handler context

Which issue(s) this PR fixes (resolves / be part of):

fixes #2597

Other special notes for the reviewers:

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2023

Codecov Report

Merging #2653 (886f93a) into main (a006328) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #2653      +/-   ##
==========================================
- Coverage   84.99%   84.85%   -0.15%     
==========================================
  Files          88       88              
  Lines        3873     3875       +2     
==========================================
- Hits         3292     3288       -4     
- Misses        409      413       +4     
- Partials      172      174       +2     
Impacted Files Coverage Δ
middleware/recovery/recovery.go 100.00% <100.00%> (ø)
config/file/watcher.go 59.37% <0.00%> (-6.25%) ⬇️
config/file/file.go 61.90% <0.00%> (-4.77%) ⬇️
internal/context/context.go 97.01% <0.00%> (-2.99%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@shenqidebaozi shenqidebaozi merged commit 19f008b into go-kratos:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] 使用 middleware/recovery 无法获取请求耗时,是否可以加上耗时参数??
3 participants