Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix contrib registry eureka watcher as *watcher #2693

Merged
merged 2 commits into from
Mar 9, 2023
Merged

fix: fix contrib registry eureka watcher as *watcher #2693

merged 2 commits into from
Mar 9, 2023

Conversation

yonwoo9
Copy link
Contributor

@yonwoo9 yonwoo9 commented Mar 2, 2023

Description (what this PR does / why we need it):

modify contrib registry eureka watcher as *watcher, defer ticker stop

Which issue(s) this PR fixes (resolves / be part of):

Other special notes for the reviewers:

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2023

Codecov Report

Merging #2693 (0be2e66) into main (c65f823) will not change coverage.
The diff coverage is n/a.

❗ Current head 0be2e66 differs from pull request most recent head 7dd65c9. Consider uploading reports for the commit 7dd65c9 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #2693   +/-   ##
=======================================
  Coverage   84.88%   84.88%           
=======================================
  Files          88       88           
  Lines        3889     3889           
=======================================
  Hits         3301     3301           
  Misses        413      413           
  Partials      175      175           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tonybase tonybase merged commit 665a72e into go-kratos:main Mar 9, 2023
@yonwoo9 yonwoo9 deleted the fix_eureka_watcher branch March 9, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants