Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove the dependency of grpc_testing module #2824

Merged
merged 1 commit into from
May 9, 2023

Conversation

fifsky
Copy link
Contributor

@fifsky fifsky commented May 9, 2023

google.golang.org/grpc v1.55.0 已经移除了grpc_tesing模块,errors单元测试看起来也没有必要依赖这个包,因此移除依赖

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2023

Codecov Report

Merging #2824 (8ed870f) into main (56777ee) will not change coverage.
The diff coverage is n/a.

❗ Current head 8ed870f differs from pull request most recent head b26f669. Consider uploading reports for the commit b26f669 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #2824   +/-   ##
=======================================
  Coverage   84.48%   84.48%           
=======================================
  Files          88       88           
  Lines        3925     3925           
=======================================
  Hits         3316     3316           
  Misses        434      434           
  Partials      175      175           

@shenqidebaozi shenqidebaozi merged commit 4a56b56 into go-kratos:main May 9, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants