Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: http parse pb message body panic #2847

Merged
merged 3 commits into from
May 29, 2023
Merged

Conversation

shifengbin
Copy link
Contributor

fix #2782

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2023

Codecov Report

Merging #2847 (6933316) into main (96480c1) will increase coverage by 0.09%.
The diff coverage is 83.33%.

❗ Current head 6933316 differs from pull request most recent head 11fbdda. Consider uploading reports for the commit 11fbdda to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #2847      +/-   ##
==========================================
+ Coverage   84.48%   84.57%   +0.09%     
==========================================
  Files          88       88              
  Lines        3925     3936      +11     
==========================================
+ Hits         3316     3329      +13     
+ Misses        434      433       -1     
+ Partials      175      174       -1     
Impacted Files Coverage Δ
encoding/proto/proto.go 89.47% <83.33%> (-10.53%) ⬇️

... and 2 files with indirect coverage changes

@daemon365 daemon365 added the LGTM label May 26, 2023
@shenqidebaozi shenqidebaozi changed the title fix #2782 fix: http parse pb message body panic May 29, 2023
@shenqidebaozi shenqidebaozi merged commit 49ffd95 into go-kratos:main May 29, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kratos http parse pb message body panic
4 participants