fix logging middle don't get trace_id value when logger is filterLogger #2869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix logging middle don't get trace_id value when logger is filterLogger Which issue(s) this PR fixes (resolves / be part of): go-kratos#2570 go-kratos#2571
freezeChen
changed the title
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #2869 +/- ##
==========================================
+ Coverage 84.42% 84.47% +0.04%
==========================================
Files 88 88
Lines 3936 3948 +12
==========================================
+ Hits 3323 3335 +12
Misses 437 437
Partials 176 176
|
shenqidebaozi
approved these changes
Jun 16, 2023
tonybase
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (what this PR does / why we need it):
fix logging middle don't get trace_id value when logger is filterLogger
Which issue(s) this PR fixes (resolves / be part of):
#2570
#2571