Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add omitempty prefix to rule path #2870

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Conversation

tonybase
Copy link
Member

@tonybase tonybase commented Jun 16, 2023

flags:
-omitempty=false
-omitempty_prefix=/api

protoc --proto_path=.  --go-http_out=omitempty=false,omitempty_prefix=/api,paths=source_relative:. service.proto

rpc SayHello (HelloRequest) returns (HelloReply) {
    option (google.api.http) = {
        get: ""
    }
}

generated path:
/api/helloworld.v1.Greeter/SayHello

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2023

Codecov Report

Merging #2870 (e938bd9) into main (e86ad24) will increase coverage by 0.05%.
The diff coverage is n/a.

❗ Current head e938bd9 differs from pull request most recent head e8bce5b. Consider uploading reports for the commit e8bce5b to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #2870      +/-   ##
==========================================
+ Coverage   84.42%   84.47%   +0.05%     
==========================================
  Files          88       88              
  Lines        3936     3936              
==========================================
+ Hits         3323     3325       +2     
+ Misses        437      435       -2     
  Partials      176      176              

see 1 file with indirect coverage changes

@shenqidebaozi shenqidebaozi changed the title add omitempty prefix to rule path feat: add omitempty prefix to rule path Jun 16, 2023
shenqidebaozi
shenqidebaozi previously approved these changes Jun 16, 2023
@tonybase tonybase merged commit 32c0d2d into main Jun 16, 2023
63 checks passed
@tonybase tonybase deleted the cmd/http-omitempty-prefix branch June 16, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants