Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bindQuery default #2915

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

hoslo
Copy link
Contributor

@hoslo hoslo commented Jul 13, 2023

Description (what this PR does / why we need it):

Cannot bind Query and Body at the same time when you make a Post request;, should be able to bind them at the same time

Which issue(s) this PR fixes (resolves / be part of):

fixes #2907

Other special notes for the reviewers:

shenqidebaozi
shenqidebaozi previously approved these changes Jul 14, 2023
daemon365
daemon365 previously approved these changes Jul 14, 2023
@hoslo hoslo dismissed stale reviews from daemon365 and shenqidebaozi via 7cf17e6 July 28, 2023 02:58
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2023

Codecov Report

Merging #2915 (06a969e) into main (bffc1a0) will not change coverage.
The diff coverage is n/a.

❗ Current head 06a969e differs from pull request most recent head 7cf17e6. Consider uploading reports for the commit 7cf17e6 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #2915   +/-   ##
=======================================
  Coverage   84.43%   84.43%           
=======================================
  Files          88       88           
  Lines        3976     3976           
=======================================
  Hits         3357     3357           
  Misses        443      443           
  Partials      176      176           

@shenqidebaozi shenqidebaozi merged commit e2a0bac into go-kratos:main Jul 28, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post requests do not support binding both body and query
5 participants