Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:go-http plugin path encoding error #2917

Merged
merged 3 commits into from
Aug 4, 2023

Conversation

J-guanghua
Copy link
Contributor

Description (what this PR does / why we need it):

Which issue(s) this PR fixes (resolves / be part of):

fix(kratos/cmd/protoc-gen-go-http/http.go:243) go-http plugin path encoding error #2873

Other special notes for the reviewers:

songzhibin97
songzhibin97 previously approved these changes Jul 28, 2023
daemon365
daemon365 previously approved these changes Jul 28, 2023
@J-guanghua J-guanghua dismissed stale reviews from daemon365 and songzhibin97 via e46937f July 28, 2023 13:51
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2023

Codecov Report

Merging #2917 (415088e) into main (bffc1a0) will not change coverage.
Report is 4 commits behind head on main.
The diff coverage is n/a.

❗ Current head 415088e differs from pull request most recent head 0c53d4b. Consider uploading reports for the commit 0c53d4b to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #2917   +/-   ##
=======================================
  Coverage   84.43%   84.43%           
=======================================
  Files          88       88           
  Lines        3976     3976           
=======================================
  Hits         3357     3357           
  Misses        443      443           
  Partials      176      176           

@shenqidebaozi shenqidebaozi merged commit 79e862d into go-kratos:main Aug 4, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants