Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): config support custom merge config #3106

Merged
merged 8 commits into from
Dec 4, 2023

Conversation

shenqidebaozi
Copy link
Sponsor Member

Description (what this PR does / why we need it):

Which issue(s) this PR fixes (resolves / be part of):

Other special notes for the reviewers:

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (d13071e) 84.28% compared to head (729f48b) 84.37%.

❗ Current head 729f48b differs from pull request most recent head 0d11490. Consider uploading reports for the commit 0d11490 to get more accurate results

Files Patch % Lines
config/config.go 0.00% 2 Missing and 1 partial ⚠️
config/reader.go 0.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3106      +/-   ##
==========================================
+ Coverage   84.28%   84.37%   +0.09%     
==========================================
  Files          88       88              
  Lines        3984     3988       +4     
==========================================
+ Hits         3358     3365       +7     
+ Misses        449      447       -2     
+ Partials      177      176       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the LGTM label Dec 4, 2023
@shenqidebaozi shenqidebaozi changed the title feat(config): config support custom mergo config feat(config): config support custom merge config Dec 4, 2023
@shenqidebaozi shenqidebaozi merged commit cd9ef38 into main Dec 4, 2023
65 checks passed
@shenqidebaozi shenqidebaozi deleted the feat/config/mergo-option branch December 4, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants