Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logging middleware caller issue #3133 #3134

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

kvii
Copy link
Contributor

@kvii kvii commented Dec 25, 2023

Description (what this PR does / why we need it):

Fix caller path issue in logging middleware.

Which issue(s) this PR fixes (resolves / be part of):

fixes/resolves #3133

Other special notes for the reviewers:

Testing code maybe a little bit hard for understanding.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (856bc9a) 84.43% compared to head (1f1fcb7) 84.69%.
Report is 4 commits behind head on main.

❗ Current head 1f1fcb7 differs from pull request most recent head 7b0891b. Consider uploading reports for the commit 7b0891b to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3134      +/-   ##
==========================================
+ Coverage   84.43%   84.69%   +0.26%     
==========================================
  Files          88       88              
  Lines        3983     3986       +3     
==========================================
+ Hits         3363     3376      +13     
+ Misses        443      438       -5     
+ Partials      177      172       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the LGTM label Jan 7, 2024
@kvii
Copy link
Contributor Author

kvii commented Feb 2, 2024

@hawkingrei Could you help me to review this code? Changes are well-tested and there was no lint issue.

@daemon365 daemon365 merged commit ffa1dca into go-kratos:main Mar 15, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logging.Server prints a wrong caller path
4 participants