Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: zap log print out multiple msg #3171

Merged
merged 3 commits into from
Feb 2, 2024
Merged

fix: zap log print out multiple msg #3171

merged 3 commits into from
Feb 2, 2024

Conversation

fzdwx
Copy link
Contributor

@fzdwx fzdwx commented Jan 24, 2024

Description (what this PR does / why we need it):

Use zlog.Info(xxx) will output multiple msg pairs:

zlog.Info("hello wolrd")

output:		{"level":"info","msg":"","msg":"hello world"}
we need: 	{"level":"info","msg":"hello world"}

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 24, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jan 24, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a556a2b) 84.62% compared to head (2f034b4) 84.72%.

❗ Current head 2f034b4 differs from pull request most recent head 48afae8. Consider uploading reports for the commit 48afae8 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3171      +/-   ##
==========================================
+ Coverage   84.62%   84.72%   +0.10%     
==========================================
  Files          88       88              
  Lines        3993     3993              
==========================================
+ Hits         3379     3383       +4     
+ Misses        440      438       -2     
+ Partials      174      172       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the LGTM label Jan 30, 2024
@hawkingrei hawkingrei merged commit c7fa51d into go-kratos:main Feb 2, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants