Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nacos stop cannot cancel subscription #3173

Merged
merged 2 commits into from Mar 20, 2024

Conversation

chenliang
Copy link
Contributor

Description (what this PR does / why we need it):

nacos stop cannot cancel subscription. causing the callback channel to be blocked, the new Watcher cannot receive the callback notification and gets the connection timeout

Which issue(s) this PR fixes (resolves / be part of):

Other special notes for the reviewers:

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 25, 2024
@chenliang chenliang changed the title nacos stop cannot cancel subscription fix:nacos stop cannot cancel subscription Jan 25, 2024
@chenliang chenliang changed the title fix:nacos stop cannot cancel subscription fix: nacos stop cannot cancel subscription Jan 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.64%. Comparing base (1ab258e) to head (a87785e).

❗ Current head a87785e differs from pull request most recent head 9135ba1. Consider uploading reports for the commit 9135ba1 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3173      +/-   ##
==========================================
+ Coverage   81.54%   81.64%   +0.09%     
==========================================
  Files          91       91              
  Lines        4167     4167              
==========================================
+ Hits         3398     3402       +4     
+ Misses        589      587       -2     
+ Partials      180      178       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the LGTM label Mar 16, 2024
@daemon365 daemon365 merged commit cd9857f into go-kratos:main Mar 20, 2024
36 checks passed
@chenliang chenliang deleted the fix_nacos_unsubscribe branch March 20, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants