added constructors for Entry and EntryAttribute #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevekuznetsov
force-pushed
the
new-entry
branch
from
69e85de
to
ca6ea27
Compare
| } | ||
| } | ||
|
|
||
| func representAsBytes(values []string) [][]byte { |
There was a problem hiding this comment.
I would inline this in NewEntryAttribute
stevekuznetsov
force-pushed
the
new-entry
branch
from
ca6ea27
to
de8e3d4
Compare
|
@liggitt Addressed comment |
stevekuznetsov
force-pushed
the
new-entry
branch
from
de8e3d4
to
18020ef
Compare
|
@liggitt Thoughts? |
|
LGTM Thanks @stevekuznetsov |
johnweldon
added a commit
that referenced
this pull request
Nov 5, 2015
added constructors for Entry and EntryAttribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When consumers of this package do unit testing they will invariably mock out LDAP entries. It is useful to expose a nice constructor for this object so that they do not have to do so manually.
/cc @johnweldon @liggitt