IsErrorAnyOf should match the given result code even if the error is wrapped #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI job failed, but it is another issue instead of this PR. https://github.com/go-ldap/ldap/actions/runs/6781841980/job/18432888679#step:5:67 |
https://github.com/go-ldap/ldap/actions/runs/6781841980/job/18726095280?pr=471 |
|
Still, three jobs are left. Could you re-run or permit me to run CI jobs? |
|
I will rebase from #473 if it would be merged first. Then, CI jobs will be passed. |
t2y
force-pushed
the
refactor-is-error-any-of
branch
from
3c806a3
to
00afd10
Compare
|
As intended. |
|
Thank you again @t2y |
gustavoluvizotto
pushed a commit
to gustavoluvizotto/ldap-fork
that referenced
this pull request
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might break compatibility, but I guess that most developers want this behavior. What do you think?