Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Mark public Start function as deprecated (closes #356) #499

Merged
merged 3 commits into from Apr 1, 2024

Conversation

cpuschma
Copy link
Member

@cpuschma cpuschma commented Apr 1, 2024

No description provided.

@cpuschma cpuschma merged commit f09ee91 into go-ldap:master Apr 1, 2024
21 checks passed
@cpuschma cpuschma deleted the chore/start_func branch April 1, 2024 18:53
gustavoluvizotto pushed a commit to gustavoluvizotto/ldap-fork that referenced this pull request Apr 11, 2024
cpuschma added a commit to cpuschma/ldap that referenced this pull request Apr 12, 2024
cpuschma added a commit that referenced this pull request Apr 12, 2024
* Revert "chore: add comment to `Start` function to inform about possible instability when called (#499)"

This reverts commit f09ee91.

* chore: add warning to `Start` comment to inform about possible race conditions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants