Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix control round-tripping, parsing #83

Merged
merged 3 commits into from
Aug 8, 2016
Merged

Fix control round-tripping, parsing #83

merged 3 commits into from
Aug 8, 2016

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Aug 7, 2016 •
edited
Loading

Fixes #82, fixes #85

  • DecodeControl(DecodePacket(bytes)) already worked correctly
  • pagingControl.Encode().Data already worked correctly
  • DecodeControl(pagingControl.Encode()) failed, since it didn't actually use the bytes in the packet, and just tried to cast the Value field

@liggitt liggitt mentioned this pull request Aug 7, 2016
Closed
@liggitt liggitt mentioned this pull request Aug 8, 2016
Closed
@liggitt liggitt changed the title Fix paging control encode value Fix control round-tripping, parsing Aug 8, 2016
@liggitt liggitt merged commit d0a5ced into go-ldap:master Aug 8, 2016
@vetinari vetinari mentioned this pull request Aug 14, 2016
Closed
vetinari added a commit to vetinari/ldap that referenced this pull request Aug 15, 2016
@vetinari
fix panic in addControlDescriptions()
dee83a3 
apply similar patch like in go-ldap#83, closes go-ldap#86
@vetinari vetinari mentioned this pull request Aug 15, 2016
Closed
@liggitt liggitt deleted the control_test branch September 13, 2016 18:23
vetinari added a commit to vetinari/ldap that referenced this pull request Sep 24, 2016
@vetinari
fix panic in addControlDescriptions()
29b8f79 
* apply similar patch like in go-ldap#83, closes go-ldap#86
* add tests for adding ControlDescriptions
@vetinari vetinari mentioned this pull request Sep 24, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic in DecodeControl when crititcality is missing cannot decode encoded paging control
1 participant
@liggitt