llvm: Add type to const declarations, update example and other cleanups. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add explicit type to constant declarations. - Attribute - ByteOrdering - CallConv - FloatPredicate - IntPredicate - Linkage - Opcode - TypeKind - VerifierFailureAction - Visibility * Remove makefiles. * Change error check order, making it more similar to "if err != nil": - from: if fail == 0 - to: if fail != 0 * Minor comment adjustments to make the godoc documentation better. llvm/examples/factorial: Updated import statement.
|
Wow, thanks for the cleanup! Looks like you've been pretty thorough, but as a rule I like to check myself that llgo/gollvm work well with patches before accepting them. I probably won't be able to do so until the weekend. |
|
Totally understandable. If you have any questions about the changes or want to discuss some details, feel free :) I've been following the llgo compiler development for quite some time, and really appreciate your work. |
|
Sorry for the delay; looks good, I'm happy to pull this in. Thanks again! |
axw
added a commit
that referenced
this pull request
Dec 2, 2012
llvm: Add type to const declarations, update example and other cleanups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm/examples/factorial: Updated import statement.