-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong line reported #6
Comments
Yep, I was coming here to file the same issue. Zapr changes the call stack, but doesn't use the AddCallerSkip option to adjust the frames to the caller. |
naemono
added a commit
to naemono/zapr
that referenced
this issue
Oct 21, 2019
naemono
added a commit
to naemono/zapr
that referenced
this issue
Oct 21, 2019
DirectXMan12
pushed a commit
that referenced
this issue
Nov 5, 2019
Closed
This does fix it for the exact bug reportet, but does break again when using WithName or WithValues since those are not supposed to add an additional skip . |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Running the example program from the README prints this line:
I would expect it to print the file and line of the program, rather than a line within zapr.go.
The text was updated successfully, but these errors were encountered: