New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong line reported #13

Closed

ralf-cestusio opened this issue Dec 19, 2019 · 0 comments · Fixed by #14

ralf-cestusio commented Dec 19, 2019

With the changes to fix #6 now creating loggers using WithName or WithValues now skips to many levels of callstack
e.g.

log = zapr.NewLogger(zapLog).WithValues("version", Version).WithName("test")
log.V(0).Info("Initializing")

now prints

{"level":"info","ts":1576782453.943943,"logger":"test","caller":"runtime/asm_amd64.s:1357","msg":"Initializing","version":""}```

AddCallerSkip should only skip a level on a "root" logger

The text was updated successfully, but these errors were encountered:

ralf-cestusio mentioned this issue

Fix caller for loggers created WithName or WithValues #14

Merged

DirectXMan12 closed this as completed in #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment