Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parsing errors from setWithProperType never get bubbled up #14

Closed
woodsaj opened this issue Nov 14, 2016 · 0 comments · Fixed by #15
Closed

parsing errors from setWithProperType never get bubbled up #14

woodsaj opened this issue Nov 14, 2016 · 0 comments · Fixed by #15

Comments

@woodsaj
Copy link
Contributor

woodsaj commented Nov 14, 2016

https://github.com/go-macaron/binding/blob/master/binding.go#L564

setWithProperType takes the Errors slice and appends to it, but never passes it back. As the slice is passed by value and not by reference the errors appended within setWithProperType are not visible to the caller.
@woodsaj woodsaj mentioned this issue Nov 14, 2016
Merged
woodsaj added a commit to woodsaj/binding that referenced this issue Nov 15, 2016
@woodsaj
capture errors when parsing values fixes go-macaron#14
a453235 
- ensure errors from setWithProperType are captured
- extend unit test to ensure that errors are captured
@woodsaj woodsaj mentioned this issue Nov 15, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

capture errors when parsing values woodsaj/binding
1 participant
@woodsaj