Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go 1.15: conversion from int64 to string yields a string of one rune #204

Closed
eclipseo opened this issue Jul 29, 2020 · 0 comments · Fixed by #205
Closed

Go 1.15: conversion from int64 to string yields a string of one rune #204

eclipseo opened this issue Jul 29, 2020 · 0 comments · Fixed by #205

Comments

@eclipseo
Copy link
Contributor

Go 1.15 rc 1 on Fedora Rawhide:

Testing    in: /builddir/build/BUILD/macaron-1.3.9/_build/src
         PATH: /builddir/build/BUILD/macaron-1.3.9/_build/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin
       GOPATH: /builddir/build/BUILD/macaron-1.3.9/_build:/usr/share/gocode
  GO111MODULE: off
      command: go test -buildmode pie -compiler gc -ldflags "-X gopkg.in/macaron.v1/version=1.3.9 -extldflags '-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '"
      testing: gopkg.in/macaron.v1
gopkg.in/macaron.v1
# gopkg.in/macaron.v1
./static.go:186:29: conversion from int64 to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
./static_test.go:200:23: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
./static_test.go:214:23: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
FAIL	gopkg.in/macaron.v1 [build failed]

See golang/go#32479
eclipseo added a commit to eclipseo/macaron that referenced this issue Jul 29, 2020
@eclipseo
Convert int to string using fmt.Sprintf
d2043f8 
See golang/go#32479

Fix go-macaron#204.

Signed-off-by: Robert-André Mauchin <zebob.m@gmail.com>
@eclipseo eclipseo mentioned this issue Jul 29, 2020
Merged
eclipseo added a commit to eclipseo/macaron that referenced this issue Jul 30, 2020
@eclipseo
Convert int to string using fmt.Sprintf
823f0d7 
See golang/go#32479

Fix go-macaron#204.

Signed-off-by: Robert-André Mauchin <zebob.m@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert int to string using fmt.Sprintf eclipseo/macaron
1 participant
@eclipseo