Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert int to string using fmt.Sprintf #205

Merged
merged 1 commit into from
Aug 17, 2020

Conversation

eclipseo
Copy link
Contributor

See golang/go#32479

Fix #204.

Signed-off-by: Robert-André Mauchin zebob.m@gmail.com

@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #205 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #205   +/-   ##
=======================================
  Coverage   91.81%   91.81%           
=======================================
  Files          11       11           
  Lines        1564     1564           
=======================================
  Hits         1436     1436           
  Misses         96       96           
  Partials       32       32           
Impacted Files Coverage Δ
static.go 90.55% <100.00%> (ø)

static.go Outdated Show resolved Hide resolved
See golang/go#32479

Fix go-macaron#204.

Signed-off-by: Robert-André Mauchin <zebob.m@gmail.com>
@eclipseo eclipseo force-pushed the fix_conversion_int_to_string branch from d2043f8 to 823f0d7 Compare July 30, 2020 14:38
@eclipseo
Copy link
Contributor Author

Yes sorry.

@unknwon
Copy link
Contributor

unknwon commented Aug 17, 2020

@humaidq @eclipseo: Thank you both!

@unknwon unknwon merged commit d229aed into go-macaron:master Aug 17, 2020
ihuanglei added a commit to ihuanglei/macaron that referenced this pull request Oct 6, 2020
Convert int to string using fmt.Sprintf (go-macaron#205)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Go 1.15: conversion from int64 to string yields a string of one rune
3 participants