Replace bad not found check in Update. #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Update` was assuming that, if no document was updated, the selector query wasn't matching anything, thus returning `ErrNotFound`. That's wrong, because it can happen that the selector matches but then the new updated value is jus the same as the old one, in which case `nModified` is 0 even if the query is successful. Now `LastError` has a `Found` method that returns true if `result.N` is greater than zero. `Update` checks that method instead of `UpdatedExisting`. I haven't added a test nor run the existing ones because apparently they need a quite complex previous setup in your machine. Sorry for that.
|
Thanks for the contribution. Let's please avoid adding a new method, as it's unrelated to the bug being fixed and we don't need to agree on it right now (LastError.Found is misleading, for example). Then, we do need tests for it. You can start servers in your machine by running "make startdb" before running the test suite. If you don't want to do this, please just open an issue including a snippet that demonstrates the bug and I'll fix it locally. |
|
Also, please mention which server versions you are testing this under. |
|
Sorry, this cannot wait. I've fixed it and will tag a new release shortly. |
|
This is out. |
|
I wasn't able to make the changes in time. Thanks for taking care of it. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updatewas assuming that, if no document was updated, the selector query wasn't matching anything, thus returningErrNotFound. That's wrong, because it can happen that the selector matches but then the new updated value is jus the same as the old one, in which casenModifiedis 0 even if the query is successful.Now
LastErrorhas aFoundmethod that returns true ifresult.Nis greater than zero.Updatechecks that method instead ofUpdatedExisting.I haven't added a test nor run the existing ones because apparently they need a quite complex previous setup in your machine. Sorry for that.