Merge pull request #229 from lexis-project/master

Support string* in ByteStreamConsumer.
go-openapi · Nov 12, 2021 · 23bff48 · 23bff48
2 parents 0e1252f + 36a1a97
commit 23bff48
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/bytestream.go b/bytestream.go
@@ -76,6 +76,13 @@ func ByteStreamConsumer(opts ...byteStreamOpt) Consumer {
 			return bu.UnmarshalBinary(b)
 		}
 
+		if data != nil {
+			if str, ok := data.(*string); ok {
+				*str = string(b)
+				return nil
+			}
+		}
+
 		if t := reflect.TypeOf(data); data != nil && t.Kind() == reflect.Ptr {
 			v := reflect.Indirect(reflect.ValueOf(data))
 			if t = v.Type(); t.Kind() == reflect.Slice && t.Elem().Kind() == reflect.Uint8 {

diff --git a/bytestream_test.go b/bytestream_test.go
@@ -21,6 +21,12 @@ func TestByteStreamConsumer(t *testing.T) {
 		assert.Equal(t, expected, b.String())
 	}
 
+	//can consume as a string
+	var s string
+	if assert.NoError(t, cons.Consume(bytes.NewBufferString(expected), &s)) {
+		assert.Equal(t, expected, s)
+	}	
+
 	// can consume as an UnmarshalBinary
 	var bu binaryUnmarshalDummy
 	if assert.NoError(t, cons.Consume(bytes.NewBufferString(expected), &bu)) {