Issue: #1917 in github.com/go-swagger/go-swagger: Don't attempt to unmarshal empty response bodies to prevent panic. #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
==========================================
- Coverage 80.65% 80.59% -0.07%
==========================================
Files 40 40
Lines 2290 2293 +3
==========================================
+ Hits 1847 1848 +1
- Misses 344 345 +1
- Partials 99 100 +1
Continue to review full report at Codecov.
|
…marshal empty response bodies to prevent panic. Signed-off-by: jwalter1-quest <jeff.walter@quest.com>
casualjim
approved these changes
Apr 11, 2019
kzys
pushed a commit
to kzys/runtime
that referenced
this pull request
Dec 17, 2022
This version of vsock fully supports Go 1.12 runtime network poller integration, and is compliant with net.Listener and net.Conn as checked by golang.org/x/net/nettest. Fixes go-openapi#135. Signed-off-by: Matt Layher <mdlayher@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short-circuited the unmarshaling in the TextConsumer when response body is empty.