changes for go-swagger #2054 - extension fields in info.contact do no… #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t propagate to embedded spec
golangcibot
reviewed
Jan 9, 2020
| @@ -14,11 +14,41 @@ | |||
|
|
|||
| package spec | |||
|
|
|||
| import ( | |||
| "encoding/json" | |||
There was a problem hiding this comment.
File is not goimports-ed (from goimports)
Suggested change
| "encoding/json" | |
| "encoding/json" | |
| @@ -14,10 +14,40 @@ | |||
|
|
|||
| package spec | |||
|
|
|||
| import ( | |||
| "encoding/json" | |||
There was a problem hiding this comment.
File is not goimports-ed (from goimports)
Suggested change
| "encoding/json" | |
| "encoding/json" | |
| @@ -15,24 +15,33 @@ | |||
| package spec | |||
|
|
|||
| import ( | |||
| "encoding/json" | |||
| "github.com/stretchr/testify/assert" | |||
There was a problem hiding this comment.
File is not goimports-ed (from goimports)
Suggested change
| "github.com/stretchr/testify/assert" |
…t propagate to embedded spec
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
=========================================
Coverage ? 58.42%
=========================================
Files ? 24
Lines ? 2189
Branches ? 0
=========================================
Hits ? 1279
Misses ? 736
Partials ? 174
Continue to review full report at Codecov.
|
…t propagate to embedded spec Signed-off-by: kul-amr <amruta9.kulkarni@gmail.com>
…t propagate to embedded spec Signed-off-by: kul-amr <amruta9.kulkarni@gmail.com>
…r_2054_spec Signed-off-by: Amruta Kulkarni <amruta9.kulkarni@gmail.com>
From last commit at OAI/OpenAPI-Specification@88cd944. Signed-off-by: kul-amr <amruta9.kulkarni@gmail.com>
`~/go/bin/go-bindata -pkg spec -prefix schemas schemas/jsonschema-draft-04.json schemas/v2/schema.json` Signed-off-by: kul-amr <amruta9.kulkarni@gmail.com>
This PR bumbs go-yaml to v2.2.4, which has the ddos vulnerability fixed. Issue: go-yaml preceding 2.2.4 had vulnerability to ddos attack via billion laughs bomb. Such attack lead to program to be unresponsive. Issue has been described in https://raesene.github.io/blog/2019/10/15/From-stackoverflow-to-CVE/ Signed-off-by: Petr Kotas <petr.kotas@gmail.com> Signed-off-by: kul-amr <amruta9.kulkarni@gmail.com>
Fixes ref rebasing when following nested $ref in Paths section Signed-off-by: Frederic BIDON <fredbi@yahoo.com> Signed-off-by: kul-amr <amruta9.kulkarni@gmail.com>
…t propagate to embedded spec Signed-off-by: kul-amr <amruta9.kulkarni@gmail.com>
…t propagate to embedded spec Signed-off-by: kul-amr <amruta9.kulkarni@gmail.com>
casualjim
approved these changes
Jan 28, 2020
|
can you run: |
ohtake
added a commit
to ohtake/go-restful
that referenced
this pull request
Feb 13, 2020
Fix examples to follow breaking changes in go-openapi/spec#113
emicklei
pushed a commit
to emicklei/go-restful
that referenced
this pull request
Feb 16, 2020
Fix examples to follow breaking changes in go-openapi/spec#113
emicklei
pushed a commit
to emicklei/go-restful
that referenced
this pull request
Feb 16, 2020
Fix examples to follow breaking changes in go-openapi/spec#113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of bug fix for go-swagger/go-swagger#2054. This fix will include extension/custom fields from Contact and License to the spec served by the generated server.