Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default barcode quality to 100 #34

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Conversation

ingfdoaguirre
Copy link
Contributor

No description provided.

Copy link
Contributor

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR.

I suspect this is needed to get barcodes that are better read by optical devices ?

contrib/barcode/barcode.go Outdated Show resolved Hide resolved
Co-authored-by: Sebastien Binet <binet@cern.ch>
@ingfdoaguirre
Copy link
Contributor Author

thanks for the PR.

I suspect this is needed to get barcodes that are better read by optical devices ?

Hi Sbinet, thats correct, I was printing some pdfs with QRcodes and the quality were OK, but when an optical devices tried to make a reading, it has problems.

I made a custom converter for my app, but I think that this needs to be in the main library by default

image

The image in the right is the current 70% default quality, and the left one is with 100% quality

Thank you!

@flibustenet
Copy link
Contributor

Wouldn't it be better in png?

@ingfdoaguirre
Copy link
Contributor Author

ingfdoaguirre commented Mar 14, 2023 via email

@sbinet sbinet merged commit ed4c0af into go-pdf:main Apr 3, 2023
@sbinet
Copy link
Contributor

sbinet commented Apr 3, 2023

thanks, and apologies for the belated answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants