Add new algorithms supported in firmware 5.7.x #157
+565
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit supports the new algorithms supported on YubiKeys with a 5.7.x firmware. It adds support for RSA-3072, RSA-4096, Ed25519, and X25519. Generating or importing X25519 keys is only supported with Go 1.20+, which adds support for the crypto/ecdh package.
hslatman
reviewed
Sep 24, 2024
hslatman
approved these changes
Sep 24, 2024
ericchiang
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
https://go.dev/doc/devel/release#policy
Versions of Go earlier than 1.20 are no longer supported. Let's not bother with this?
| "fmt" | ||
| ) | ||
|
|
||
| type X25519PrivateKey struct { |
There was a problem hiding this comment.
Please add a comment to this exported type similar to ECDSAPrivateKey, explaining that users are expected to type case private keys to this type.
https://pkg.go.dev/github.com/go-piv/piv-go/v2/piv#ECDSAPrivateKey
| }) | ||
| } | ||
|
|
||
| func (yk *YubiKey) tryX25519PrivateKey(slot Slot, public crypto.PublicKey, auth KeyAuth, pp PINPolicy) (crypto.PrivateKey, error) { |
There was a problem hiding this comment.
Go generally doesn't use "try" in the method name
newX25519PrivateKey()
| } | ||
| } | ||
|
|
||
| func (yk *YubiKey) tryX22519PrivateKeyInsecure(private crypto.PrivateKey) ([][]byte, byte, int, error) { |
There was a problem hiding this comment.
"setX22519PrivateKeyInsecure"
There was a problem hiding this comment.
ditto: let's remove this and drop support for earlier versions of Go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit supports the new algorithms supported on YubiKeys with a 5.7.x firmware. It adds support for RSA-3072, RSA-4096, Ed25519, and X25519.
Generating X25519 keys is only supported with Go 1.20+, which adds support for the
crypto/ecdhpackage.Note that this commit removes the support for Ed25519 on SoloKeys if the algorithm identifier is set to 0x22.
Fixes #143