-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support twitter auth #33
Conversation
Pull Request Test Coverage Report for Build 257
💛 - Coveralls |
very nice, thx! From first glance, it looks good and clean, but I'll take a closer looks tonight (hopefully). Have you tried to run it with the real twitter auth? |
yeap, I tried to run There is one thing I am not sure about this implementation though. It is usage of |
|
||
claims := token.Claims{ | ||
Handshake: &token.Handshake{ | ||
State: requestSecret, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here requestSecret
is set for later usage in AuthHandler
makes sense. |
To resolve #31